nomicon/pkgs/tools/admin/salt/default.nix

{ lib
, python3
, openssl
  # Many Salt modules require various Python modules to be installed,
  # passing them in this array enables Salt to find them.
, extraInputs ? []
}:

python3.pkgs.buildPythonApplication rec {
  pname = "salt";
  version = "3004.1";

  src = python3.pkgs.fetchPypi {
    inherit pname version;
    hash = "sha256-fzRKJDJkik8HjapazMaNzf/hCVzqE+wh5QQTVg8Ewpg=";
  };

  propagatedBuildInputs = with python3.pkgs; [
    distro
    jinja2
    markupsafe
    msgpack
    psutil
    pycryptodomex
    pyyaml
    pyzmq
    requests
  ] ++ extraInputs;

  patches = [
    ./fix-libcrypto-loading.patch

    # Bug in 3004.1: https://github.com/saltstack/salt/pull/61856
    ./0001-Fix-Jinja2-3.1.0.patch
  ];

  postPatch = ''
    substituteInPlace "salt/utils/rsax931.py" \
      --subst-var-by "libcrypto" "${lib.getLib openssl}/lib/libcrypto.so"
    substituteInPlace requirements/base.txt \
      --replace contextvars ""

    # Don't require optional dependencies on Darwin, let's use
    # `extraInputs` like on any other platform
    echo -n > "requirements/darwin.txt"

    # Bug in 3004.1: https://github.com/saltstack/salt/pull/61839
    substituteInPlace "salt/utils/entrypoints.py" \
      --replace 'if sys.version_info >= (3, 10):' 'if False:'

    # Bug in 3004.1: https://github.com/saltstack/salt/issues/61865
    substituteInPlace "salt/transport/tcp.py" \
      --replace 'payload = self.pack_publish(package)' 'package = self.pack_publish(package)'

    # 3004.1: requirement of pyzmq was restricted to <22.0.0; looks like that req was incorrect
    # https://github.com/saltstack/salt/commit/070597e525bb7d56ffadede1aede325dfb1b73a4
    # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259279
    # https://github.com/saltstack/salt/pull/61163
    substituteInPlace "requirements/zeromq.txt" \
      --replace 'pyzmq<=20.0.0 ; python_version < "3.6"' "" \
      --replace 'pyzmq>=17.0.0,<22.0.0 ; python_version < "3.9"' 'pyzmq>=17.0.0 ; python_version < "3.9"' \
      --replace 'pyzmq>19.0.2,<22.0.0 ; python_version >= "3.9"' 'pyzmq>19.0.2 ; python_version >= "3.9"'
  '';

  # Don't use fixed dependencies on Darwin
  USE_STATIC_REQUIREMENTS = "0";

  # The tests fail due to socket path length limits at the very least;
  # possibly there are more issues but I didn't leave the test suite running
  # as is it rather long.
  doCheck = false;

  meta = with lib; {
    homepage = "https://saltproject.io/";
    changelog = "https://docs.saltproject.io/en/latest/topics/releases/${version}.html";
    description = "Portable, distributed, remote execution and configuration management system";
    maintainers = with maintainers; [ Flakebi ];
    license = licenses.asl20;
  };
}
salt: 2019.2.0 -> 3000.2 4 years ago			`{ lib`
			`, python3`
			`, openssl`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`# Many Salt modules require various Python modules to be installed,`
			`# passing them in this array enables Salt to find them.`
salt: 2019.2.0 -> 3000.2 4 years ago			`, extraInputs ? []`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`}:`
salt: 3003.3 -> 3004 3 years ago
salt: 3004.1 - bugfixes (#172129) 2 years ago			`python3.pkgs.buildPythonApplication rec {`
salt: 2016.11.4 -> 2016.11.5 7 years ago			`pname = "salt";`
salt: 3004 -> 3004.1 2 years ago			`version = "3004.1";`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago
salt: 3004.1 - bugfixes (#172129) 2 years ago			`src = python3.pkgs.fetchPypi {`
salt: 2016.11.4 -> 2016.11.5 7 years ago			`inherit pname version;`
salt: 3004 -> 3004.1 2 years ago			`hash = "sha256-fzRKJDJkik8HjapazMaNzf/hCVzqE+wh5QQTVg8Ewpg=";`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`};`

salt: 3004.1 - bugfixes (#172129) 2 years ago			`propagatedBuildInputs = with python3.pkgs; [`
salt: 3000.3 -> 3001 4 years ago			`distro`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`jinja2`
			`markupsafe`
salt: 2018.3.0 -> 2018.3.2 6 years ago			`msgpack`
salt: 3003.3 -> 3004 3 years ago			`psutil`
salt: 3000.3 -> 3001 4 years ago			`pycryptodomex`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`pyyaml`
			`pyzmq`
			`requests`
			`] ++ extraInputs;`

salt: 3004.1 - bugfixes (#172129) 2 years ago			`patches = [`
			`./fix-libcrypto-loading.patch`

			`# Bug in 3004.1: https://github.com/saltstack/salt/pull/61856`
			`./0001-Fix-Jinja2-3.1.0.patch`
			`];`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago
			`postPatch = ''`
			`substituteInPlace "salt/utils/rsax931.py" \`
treewide: use lib.getLib for OpenSSL libraries At some point, I'd like to make another attempt at 71f1f4884b5 ("openssl: stop static binaries referencing libs"), which was reverted in 195c7da07df. One problem with my previous attempt is that I moved OpenSSL's libraries to a lib output, but many dependent packages were hardcoding the out output as the location of the libraries. This patch fixes every such case I could find in the tree. It won't have any effect immediately, but will mean these packages will automatically use an OpenSSL lib output if it is reintroduced in future. This patch should cause very few rebuilds, because it shouldn't make any change at all to most packages I'm touching. The few rebuilds that are introduced come from when I've changed a package builder not to use variable names like openssl.out in scripts / substitution patterns, which would be confusing since they don't hardcode the output any more. I started by making the following global replacements: ${pkgs.openssl.out}/lib -> ${lib.getLib pkgs.openssl}/lib ${openssl.out}/lib -> ${lib.getLib openssl}/lib Then I removed the ".out" suffix when part of the argument to lib.makeLibraryPath, since that function uses lib.getLib internally. Then I fixed up cases where openssl was part of the -L flag to the compiler/linker, since that unambigously is referring to libraries. Then I manually investigated and fixed the following packages: - pycurl - citrix-workspace - ppp - wraith - unbound - gambit - acl2 I'm reasonably confindent in my fixes for all of them. For acl2, since the openssl library paths are manually provided above anyway, I don't think openssl is required separately as a build input at all. Removing it doesn't make a difference to the output size, the file list, or the closure. I've tested evaluation with the OfBorg meta checks, to protect against introducing evaluation failures. 2 years ago			`--subst-var-by "libcrypto" "${lib.getLib openssl}/lib/libcrypto.so"`
salt: 3003 -> 3003.1 Need to patch out the contextvars dependency (which is included in python 3.7+). The same patch is discussed in arch: https://bugs.archlinux.org/task/71344 3 years ago			`substituteInPlace requirements/base.txt \`
			`--replace contextvars ""`
salt: 3004.1 - bugfixes (#172129) 2 years ago
			`# Don't require optional dependencies on Darwin, let's use`
			# `extraInputs` like on any other platform
			`echo -n > "requirements/darwin.txt"`

			`# Bug in 3004.1: https://github.com/saltstack/salt/pull/61839`
			`substituteInPlace "salt/utils/entrypoints.py" \`
			`--replace 'if sys.version_info >= (3, 10):' 'if False:'`

			`# Bug in 3004.1: https://github.com/saltstack/salt/issues/61865`
			`substituteInPlace "salt/transport/tcp.py" \`
			`--replace 'payload = self.pack_publish(package)' 'package = self.pack_publish(package)'`

			`# 3004.1: requirement of pyzmq was restricted to <22.0.0; looks like that req was incorrect`
			`# https://github.com/saltstack/salt/commit/070597e525bb7d56ffadede1aede325dfb1b73a4`
			`# https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259279`
			`# https://github.com/saltstack/salt/pull/61163`
			`substituteInPlace "requirements/zeromq.txt" \`
			`--replace 'pyzmq<=20.0.0 ; python_version < "3.6"' "" \`
			`--replace 'pyzmq>=17.0.0,<22.0.0 ; python_version < "3.9"' 'pyzmq>=17.0.0 ; python_version < "3.9"' \`
			`--replace 'pyzmq>19.0.2,<22.0.0 ; python_version >= "3.9"' 'pyzmq>19.0.2 ; python_version >= "3.9"'`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`'';`

salt: 3004.1 - bugfixes (#172129) 2 years ago			`# Don't use fixed dependencies on Darwin`
			`USE_STATIC_REQUIREMENTS = "0";`

salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`# The tests fail due to socket path length limits at the very least;`
			`# possibly there are more issues but I didn't leave the test suite running`
			`# as is it rather long.`
			`doCheck = false;`

salt: 2019.2.0 -> 3000.2 4 years ago			`meta = with lib; {`
salt: update meta (#116557) Salt rebranded itself from https://saltstack.com to https://saltproject.io - reflect the changes in the URLs 3 years ago			`homepage = "https://saltproject.io/";`
			`changelog = "https://docs.saltproject.io/en/latest/topics/releases/${version}.html";`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`description = "Portable, distributed, remote execution and configuration management system";`
salt: remove aneeshusa and add Flakebi as maintainer 4 years ago			`maintainers = with maintainers; [ Flakebi ];`
salt: init at 2015.8.8 Also init salttesting at 2015.7.10 as a build dependency. 8 years ago			`license = licenses.asl20;`
			`};`
			`}`