From 3e385d9a8262fedc647f59aebc5464d7a9212c1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Na=C3=AFm=20Favier?= <n@monade.li>
Date: Thu, 12 May 2022 15:23:38 +0200
Subject: [PATCH] makeBinaryWrapper: add comment

---
 .../build-support/setup-hooks/make-binary-wrapper/default.nix | 4 +---
 pkgs/test/default.nix                                         | 2 ++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pkgs/build-support/setup-hooks/make-binary-wrapper/default.nix b/pkgs/build-support/setup-hooks/make-binary-wrapper/default.nix
index 318624011b7..fd0fa3ea009 100644
--- a/pkgs/build-support/setup-hooks/make-binary-wrapper/default.nix
+++ b/pkgs/build-support/setup-hooks/make-binary-wrapper/default.nix
@@ -15,9 +15,7 @@ makeSetupHook {
     ++ lib.optional (stdenv.isDarwin && stdenv.isAarch64) darwin.cctools;
 
   substitutions = {
-    cc = let
-      san = lib.escapeShellArgs (map (s: "-fsanitize=${s}") sanitizers);
-    in "${cc}/bin/cc ${san}";
+    cc = "${cc}/bin/cc ${lib.escapeShellArgs (map (s: "-fsanitize=${s}") sanitizers)}";
 
     # Extract the function call used to create a binary wrapper from its embedded docstring
     passthru.extractCmd = writeShellScript "extract-binary-wrapper-cmd" ''
diff --git a/pkgs/test/default.nix b/pkgs/test/default.nix
index e3253498958..4b850f1509c 100644
--- a/pkgs/test/default.nix
+++ b/pkgs/test/default.nix
@@ -74,6 +74,8 @@ with pkgs;
   makeWrapper = callPackage ./make-wrapper { };
   makeBinaryWrapper = callPackage ./make-binary-wrapper {
     makeBinaryWrapper = pkgs.makeBinaryWrapper.override {
+      # Enable sanitizers in the tests only, to avoid the performance cost in regular usage.
+      # The sanitizers cause errors on aarch64-darwin, see https://github.com/NixOS/nixpkgs/pull/150079#issuecomment-994132734
       sanitizers = pkgs.lib.optionals (! (pkgs.stdenv.isDarwin && pkgs.stdenv.isAarch64))
         [ "undefined" "address" ];
     };