pe-parse: drop `no-sign-conversion` compile flag

Upstream has merged a patch to fix the issue so we can use that instead
of being lax when compiling.
main
Thomas Gerbet 2 years ago
parent 267e232035
commit 4929c80451
  1. 12
      pkgs/development/libraries/pe-parse/default.nix

@ -1,4 +1,4 @@
{ stdenv, lib, fetchFromGitHub, cmake }:
{ stdenv, lib, fetchFromGitHub, cmake, fetchpatch }:
stdenv.mkDerivation rec {
pname = "pe-parse";
@ -11,10 +11,14 @@ stdenv.mkDerivation rec {
hash = "sha256-HwWlMRhpB/sa/JRyAZF7LZzkXCCyuxB+gtDAfHt7e6k=";
};
nativeBuildInputs = [ cmake ];
patches = [
(fetchpatch {
url = "https://github.com/trailofbits/pe-parse/commit/eecdb3d36eb44e306398a2e66e85490f9bdcc74c.patch";
hash = "sha256-pd6D/JMctiQqJxnJU9Nm/GDVf4/CaIGeXx1UfdcCupo=";
})
];
# See https://github.com/trailofbits/pe-parse/issues/169
NIX_CFLAGS_COMPILE = "-Wno-sign-conversion";
nativeBuildInputs = [ cmake ];
doInstallCheck = true;
installCheckPhase = ''

Loading…
Cancel
Save