thc-hydra: 9.2 -> 9.3

* thc-hydra: 9.2 -> 9.3 (#158563)

update homepage
add meta.changelog
and use SPDX 3.0 license identifier

drop unnecessary patch for Darwin

disable on Darwin (fails to build)

Co-authored-by: Renaud <c0bw3b@users.noreply.github.com>

pkgs/tools/security/thc-hydra/darwin-remove-ldflag.patch

@@ -1,13 +0,0 @@
-diff --git a/Makefile.am b/Makefile.am
-index 1c915f1..83a8e41 100644
---- a/Makefile.am
-+++ b/Makefile.am
-@@ -4,7 +4,7 @@
- WARN_CLANG=-Wformat-nonliteral -Wstrncat-size -Wformat-security -Wsign-conversion -Wconversion -Wfloat-conversion -Wshorten-64-to-32 -Wuninitialized -Wmissing-variable-declarations  -Wmissing-declarations
- WARN_GCC=-Wformat=2 -Wformat-overflow=2 -Wformat-nonliteral -Wformat-truncation=2 -Wnull-dereference -Wstrict-overflow=2 -Wstringop-overflow=4 -Walloca-larger-than=4096 -Wtype-limits -Wconversion -Wtrampolines -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -fno-common -Wcast-align
- CFLAGS ?= -g
--OPTS=-I. -O3 $(CFLAGS) -fcommon -Wl,--allow-multiple-definition
-+OPTS=-I. -O3 $(CFLAGS) -fcommon
- # -Wall -g -pedantic
- LIBS=-lm
- DESTDIR ?=

pkgs/tools/security/thc-hydra/default.nix

@@ -3,19 +3,15 @@
 
 stdenv.mkDerivation rec {
   pname = "thc-hydra";
-  version = "9.2";
+  version = "9.3";
 
   src = fetchFromGitHub {
     owner = "vanhauser-thc";
     repo = "thc-hydra";
     rev = "v${version}";
-    sha256 = "sha256-V9rr5fbJWm0pa+Kp8g95XvLPo/uWcDwyU2goImnIq58=";
+    sha256 = "sha256-SzbaU52IXw5+ztN/GKD6Ki6/cx2icoZEzLHBu/J8sk0=";
   };
 
-  patches = lib.optionals stdenv.isDarwin [
-    ./darwin-remove-ldflag.patch
-  ];
-
   postPatch = let
     makeDirs = output: subDir: lib.concatStringsSep " " (map (path: lib.getOutput output path + "/" + subDir) buildInputs);
   in ''
@@ -44,9 +40,11 @@ stdenv.mkDerivation rec {
 
   meta = with lib; {
     description = "A very fast network logon cracker which support many different services";
-    homepage = "https://www.thc.org/thc-hydra/";
-    license = licenses.agpl3;
+    homepage = "https://github.com/vanhauser-thc/thc-hydra"; # https://www.thc.org/
+    changelog = "https://github.com/vanhauser-thc/thc-hydra/raw/v${version}/CHANGES";
+    license = licenses.agpl3Plus;
     maintainers = with maintainers; [ offline ];
     platforms = platforms.unix;
+    badPlatforms = platforms.darwin; # fails to build since v9.3
   };
 }