firefox-bin: provide wrapper with libName

The wrapper was configuring the wrong directory, and
`${libName}/firefox-bin` must not be a symlink.
main
arcnmx 3 years ago
parent de8a764559
commit 9ead68aa4b
  1. 2
      pkgs/applications/networking/browsers/firefox-bin/default.nix
  2. 6
      pkgs/applications/networking/browsers/firefox/wrapper.nix
  3. 4
      pkgs/top-level/all-packages.nix

@ -190,6 +190,8 @@ stdenv.mkDerivation {
ln -s ${policiesJson} "$out/lib/firefox-bin-${version}/distribution/policies.json";
'';
passthru.applicationName = "firefox";
passthru.libName = "firefox-bin-${version}";
passthru.execdir = "/bin";
passthru.ffmpegSupport = true;
passthru.gssSupport = true;

@ -42,7 +42,7 @@ let
# https://github.com/mozilla/policy-templates#enterprisepoliciesenabled
, extraPolicies ? {}
, extraPoliciesFiles ? []
, libName ? "firefox" # Important for tor package or the like
, libName ? browser.libName or "firefox" # Important for tor package or the like
, nixExtensions ? null
}:
@ -219,8 +219,8 @@ let
find . -type f \( -not -name "${applicationName}" \) -exec ln -sT "${browser}"/{} "$out"/{} \;
find . -type f -name "${applicationName}" -print0 | while read -d $'\0' f; do
cp -P --no-preserve=mode,ownership "${browser}/$f" "$out/$f"
find . -type f \( -name "${applicationName}" -o -name "${applicationName}-bin" \) -print0 | while read -d $'\0' f; do
cp -P --no-preserve=mode,ownership --remove-destination "${browser}/$f" "$out/$f"
chmod a+rwx "$out/$f"
done

@ -25695,9 +25695,7 @@ with pkgs;
};
firefox-bin = wrapFirefox firefox-bin-unwrapped {
applicationName = "firefox";
pname = "firefox-bin";
desktopName = "Firefox";
};
firefox-beta-bin-unwrapped = firefox-bin-unwrapped.override {
@ -25707,7 +25705,6 @@ with pkgs;
};
firefox-beta-bin = res.wrapFirefox firefox-beta-bin-unwrapped {
applicationName = "firefox";
pname = "firefox-beta-bin";
desktopName = "Firefox Beta";
};
@ -25719,7 +25716,6 @@ with pkgs;
};
firefox-devedition-bin = res.wrapFirefox firefox-devedition-bin-unwrapped {
applicationName = "firefox";
nameSuffix = "-devedition";
pname = "firefox-devedition-bin";
desktopName = "Firefox DevEdition";

Loading…
Cancel
Save