beetsExternalPlugins.check: remove (broken)

wip/yesman
Bernardo Meurer 3 years ago
parent 6beb35e344
commit a2492b0831
No known key found for this signature in database
GPG Key ID: F4C0D53B8D14C246
  1. 2
      pkgs/tools/audio/beets/default.nix
  2. 17
      pkgs/tools/audio/beets/plugins/check-tests.patch
  3. 36
      pkgs/tools/audio/beets/plugins/check.nix
  4. 1
      pkgs/top-level/all-packages.nix

@ -32,7 +32,6 @@
# External plugins
, enableAlternatives ? false
, enableCheck ? false, liboggz
, enableCopyArtifacts ? false
, enableExtraFiles ? false
@ -140,7 +139,6 @@ in pythonPackages.buildPythonApplication rec {
|| enableSubsonicplaylist
|| enableSubsonicupdate
|| enableAcousticbrainz) pythonPackages.requests
++ lib.optional enableCheck beetsExternalPlugins.check
++ lib.optional enableConvert ffmpeg
++ lib.optional enableDiscogs pythonPackages.discogs_client
++ lib.optional enableKeyfinder keyfinder-cli

@ -1,17 +0,0 @@
diff --git a/test/cli_test.py b/test/cli_test.py
index 26df140..2eb913c 100644
--- a/test/cli_test.py
+++ b/test/cli_test.py
@@ -372,12 +372,6 @@ class ToolListTest(TestHelper, TestCase):
self.assertIn('flac', stdout.getvalue())
self.assertIn('oggz-validate', stdout.getvalue())
- def test_found_mp3val(self):
- shutil.copy('/bin/echo', os.path.join(self.temp_dir, 'mp3val'))
- with captureStdout() as stdout:
- beets.ui._raw_main(['check', '--list-tools'])
- self.assertRegexpMatches(stdout.getvalue(), r'mp3val *found')
-
def test_oggz_validate_not_found(self):
with captureStdout() as stdout:
beets.ui._raw_main(['check', '--list-tools'])

@ -1,36 +0,0 @@
{ lib, fetchFromGitHub, beets, pythonPackages, flac, liboggz, mp3val }:
pythonPackages.buildPythonApplication rec {
name = "beets-check";
version = "0.12.0";
src = fetchFromGitHub {
repo = "beets-check";
owner = "geigerzaehler";
rev = "v${version}";
sha256 = "0b2ijjf0gycs6b40sm33ida3sjygjiv4spb5mba52vysc7iwmnjn";
};
nativeBuildInputs = [ beets ];
checkInputs = [ pythonPackages.nose flac liboggz mp3val ];
propagatedBuildInputs = [ flac liboggz mp3val ];
# patch out broken tests
patches = [ ./check-tests.patch ];
# patch out futures dependency, it is only needed for Python2 which we don't
# support.
prePatch = ''
sed -i "/futures/d" setup.py
'';
checkPhase = "nosetests";
meta = with lib; {
description = "Beets plugin to Verify and store checksums in your library";
homepage = "https://github.com/geigerzaehler/beets-check";
license = licenses.mit;
maintainers = with maintainers; [ lovesegfault ];
broken = true;
};
}

@ -3034,7 +3034,6 @@ in
};
in lib.recurseIntoAttrs {
alternatives = callPackage ../tools/audio/beets/plugins/alternatives.nix pluginArgs;
check = callPackage ../tools/audio/beets/plugins/check.nix pluginArgs;
copyartifacts = callPackage ../tools/audio/beets/plugins/copyartifacts.nix pluginArgs;
extrafiles = callPackage ../tools/audio/beets/plugins/extrafiles.nix pluginArgs;
};

Loading…
Cancel
Save