This commit fixes precise dependency ignorance by converting the environment variable `autoPatchelfIgnoreMissingDeps` into a bash array `ignoreMissingDepsArray`, passing `"${ignoreMissingDepsArray[@]}"` instead of `"${autoPatchelfIgnoreMissingDeps[@]}"` to the python script. The original implementation does not work when `autoPatchelfIgnoreMissingDeps` contains multiple dependency names. Because it mistakenly passes `"${autoPatchelfIgnoreMissingDeps[@]}"` to the python script. According to the Nix manual (https://nixos.org/manual/nix/stable/expressions/derivations.html), lists of strings are concatenated into whitespace-separated strings, then passed to the builder as environment variables. So, if `autoPatchelfIgnoreMissingDeps = [ "dep1" "dep2" "dep3" ]`, `"${autoPatchelfIgnoreMissingDeps[@]}"` will be expanded to a single argument `"dep1 dep2 dep3"`, which is not the intended behavior, because the python script takes the long argument as a dependency name. With this commit, `"${ignoreMissingDepsArray[@]}"` will be expanded to three arguments `"dep1" "dep2" "dep3"` arguments as expected, fixing the issue.main
parent
831a344b8b
commit
bedc267a78
Loading…
Reference in new issue