metasploit: reimplement using mkDerivation

Also fixes download location. Bumps version to 3.3.1, which is
the closest to the original version for which a source archive
is still available.

pkgs/tools/security/metasploit/3.1.nix

@@ -1,31 +0,0 @@
-args @ { makeWrapper, ... }: with args;
-rec {
-  src = fetchurl {
-    url = http://www.packetstormsecurity.nl/UNIX/utilities/framework-3.1.tar.gz;
-    sha256 = "114znq9dfcyh9gcj57p3zsc0d0amlzhwidmg8qjcgxpjh28h1afx";
-  };
-
-  buildInputs = [makeWrapper];
-  configureFlags = [];
-
-  doInstall = fullDepEntry(''
-    mkdir -p $out/share/msf
-    mkdir -p $out/bin
-
-    cp -r * $out/share/msf
-
-    for i in $out/share/msf/msf*; do
-        makeWrapper $i $out/bin/$(basename $i) --prefix RUBYLIB : $out/share/msf/lib
-    done
-  '') ["minInit" "defEnsureDir" "doUnpack" "addInputs"];
-
-  /* doConfigure should be specified separately */
-  phaseNames = ["doInstall" (doPatchShebangs "$out/share/msf")];
-
-  name = "metasploit-framework-3.1";
-  meta = {
-    description = "Metasploit Framework - a collection of exploits";
-    homepage = "http://framework.metasploit.org/";
-  };
-}
-

pkgs/tools/security/metasploit/default.nix

@@ -0,0 +1,33 @@
+{ stdenv, fetchurl, makeWrapper, ruby }:
+
+stdenv.mkDerivation rec {
+  name = "metasploit-framework-${version}";
+  version = "3.3.1";
+
+  src = fetchurl {
+    url = "http://downloads.metasploit.com/data/releases/archive/framework-${version}.tar.bz2";
+    sha256 = "07clzw1zfnqjhyydsc4mza238isai58p7aygh653qxsqb9a0j7qw";
+  };
+
+  buildInputs = [makeWrapper];
+
+  installPhase = ''
+    mkdir -p $out/share/msf
+    mkdir -p $out/bin
+
+    cp -r * $out/share/msf
+
+    for i in $out/share/msf/msf*; do
+        makeWrapper $i $out/bin/$(basename $i) --prefix RUBYLIB : $out/share/msf/lib
+    done
+  '';
+
+  postInstall = ''
+    patchShebangs $out/share/msf
+  '';
+
+  meta = {
+    description = "Metasploit Framework - a collection of exploits";
+    homepage = https://github.com/rapid7/metasploit-framework/wiki;
+  };
+}

pkgs/top-level/all-packages.nix

@@ -2294,7 +2294,7 @@ let
 
   mscgen = callPackage ../tools/graphics/mscgen { };
 
-  msf = builderDefsPackage (callPackage ../tools/security/metasploit/3.1.nix) { };
+  msf = callPackage ../tools/security/metasploit { };
 
   mssys = callPackage ../tools/misc/mssys { };