Without the change build fails on -fno-common toolchains like upstream
gcc-10 as:
$ nix build -L --impure --expr 'with import ./. {}; bwa.overrideAttrs (oa: { NIX_CFLAGS_COMPILE = (oa.NIX_CFLAGS_COMPILE or "") + "-fno-common"; })'
...
ld: ./libbwa.a(rope.o):/build/bwa-0.7.17/rle.h:33:
multiple definition of `rle_auxtab'; ./libbwa.a(bwtindex.o):/build/bwa-0.7.17/rle.h:33: first defined here
ld: ./libbwa.a(rle.o):/build/bwa-0.7.17/rle.h:33:
multiple definition of `rle_auxtab'; ./libbwa.a(bwtindex.o):/build/bwa-0.7.17/rle.h:33: first defined here
This updates k3s.
This one's done by hand rather than via the update bot since the
upstream repo ended up in a state where `go mod download` didn't work,
and we had `proxyVendor` set (which causes a `go mod download`).
Deleting `proxyVendor` works now though, and I didn't actually fully
understand why it was needed before, so I've removed that. Which
unblocks the update.
The actual update was done via `./update.sh` after removing
`proxyVendor` and the `k3sServerVendorSha256` variables.
Without the change build on -fno-common toolchains like clamng-13 fails as:
$ nix build --impure --expr 'with import ./. {}; freetalk.override { stdenv = clang13Stdenv; }' -L
...
ld: more.o:src/./more.h:15: multiple definition of `cin'; primitives.o:src/./more.h:15: first defined here
ld: more.o:src/./more.h:14: multiple definition of `initial_settings'; primitives.o:src/./more.h:14: first defined here
Without the update build fails on -fno-common toolchains as:
$ nix build --impure --expr 'with import ./. {}; bicon.override { stdenv = clang13Stdenv; }'
...
ld: bicon_bin-bicon_read.o:/build/source/bicon/bicon_read.c:37:
multiple definition of `bicon_options'; bicon_bin-bicon.o:/build/source/bicon/./bicon_read.h:4: first defined here
While at it pulled in pending fix for clang compatibility.
Without the change -fno-common toolchains like upstream gcc-10
or clang-11+ fail to build simh as:
$ nix build --impure --expr 'with import ~/nm {}; simh.override { stdenv = clang13Stdenv; }'
...
ld: /build/pdp11_io-0c74f0.o:(.bss+0x10c00):
multiple definition of `uc15_memsize'; /build/pdp11_cis-17339e.o:(.bss+0x118): first defined here
ld: /build/pdp11_io_lib-296a06.o:(.bss+0x8000):
multiple definition of `uc15_memsize'; /build/pdp11_cis-17339e.o:(.bss+0x118): first defined here
Without the change build fails on -fno-common tollchains as:
$ nix build --impure --expr 'with import ~/nm {}; wmfs.override { stdenv = clang13Stdenv; }'
...
ld: src/log.o:(.bss+0x0): multiple definition of `W'; src/barwin.o:(.bss+0x0): first defined here
ld: src/wmfs.o:(.bss+0x0): multiple definition of `W'; src/barwin.o:(.bss+0x0): first defined here
ld: src/wmfs.o:(.bss+0x10): multiple definition of `event_handle'; src/client.o:(.bss+0x10): first defined here
Robert Schütz