Without the change build fails on -fno-common toolchains like upstream
gcc-10:
$ nix build -L --impure --expr 'with import ./. {}; gtkdialog.overrideAttrs (oa: { NIX_CFLAGS_COMPILE = (oa.NIX_CFLAGS_COMPILE or []) ++ ["-fno-common"]; })'
...
ld: widget_window.o:/build/gtkdialog-0.8.3/src/gtkdialog.h:43:
multiple definition of `function_signals_block'; gtkdialog.o:/build/gtkdialog-0.8.3/src/gtkdialog.h:43: first defined here
continuation of #109595
pkgconfig was aliased in 2018, however, it remained in
all-packages.nix due to its wide usage. This cleans
up the remaining references to pkgs.pkgsconfig and
moves the entry to aliases.nix.
python3Packages.pkgconfig remained unchanged because
it's the canonical name of the upstream package
on pypi.
Sergei Trofimovich