Among other things fixes build failure on gcc-10:
ld: CMakeFiles/xsuspender.dir/xsuspender.c.o:(.bss+0x8): multiple definition of
`queued_entries'; CMakeFiles/xsuspender.dir/config.c.o:(.bss+0x8): first defined here
they're unnecessary since https://github.com/NixOS/nixpkgs/pull/161739/files
which links the schemas to their correct fhs locations and adds
gsettings-desktop-schemas and hicolor-icon-theme to appimage fhs
Without the change build fails as:
ld: editor.o:(.bss+0x8): multiple definition of `cfg_character_set'; config.o:(.bss+0x20): first defined here
ld: editor.o:(.bss+0x10): multiple definition of `cfg_character_count'; config.o:(.data+0x10): first defined here
The use of --add-flags in this derivation assumed quotes to be expanded, which the binary
wrapper (which wrapGAppsHook uses since #164163) will not do.
Without the change -fno-common toolchains like upstream gcc-10
fail to build as:
ld: stats.o:/build/cataract-675e647/src/stats.h:24: multiple definition of
`stats_images'; cgg.o:/build/cataract-675e647/src/stats.h:24: first defined here
Without the update build fails on -fno-common toolchains as:
$ nix build --impure --expr 'with import ./. {}; bicon.override { stdenv = clang13Stdenv; }'
...
ld: bicon_bin-bicon_read.o:/build/source/bicon/bicon_read.c:37:
multiple definition of `bicon_options'; bicon_bin-bicon.o:/build/source/bicon/./bicon_read.h:4: first defined here
While at it pulled in pending fix for clang compatibility.
Sergei Trofimovich