Without the change build on -fno-common toolchains like upstream gcc-10
fails as:
$ nix build -L --impure --expr 'with import ./. {}; ncrack.overrideAttrs (oa: { NIX_CFLAGS_COMPILE = (oa.NIX_CFLAGS_COMPILE or "") + "-fno-common"; })'
...
ld: opensshlib/libopenssh.a(umac128.o):/build/source/opensshlib/umac.c:1184:
multiple definition of `umac_ctx'; opensshlib/libopenssh.a(umac.o):/build/source/opensshlib/umac.c:1184: first defined here
Without the change build fails as:
$ nix build --impure --expr 'with import ./. {}; xwinmosaic.overrideAttrs (oa: { NIX_CFLAGS_COMPILE = (oa.NIX_CFLAGS_COMPILE or "") + "-fno-common"; })'
ld: CMakeFiles/xwinmosaic.dir/main.c.o:(.bss+0xc0):
multiple definition of `a_NET_CURRENT_DESKTOP'; CMakeFiles/xwinmosaic.dir/x_interaction.c.o:(.bss+0xc0): first defined here
ld: CMakeFiles/xwinmosaic.dir/main.c.o:(.bss+0xc8):
multiple definition of `a_NET_DESKTOP_VIEWPORT'; CMakeFiles/xwinmosaic.dir/x_interaction.c.o:(.bss+0xc8): first defined here
Update upterm to version 0.8.2 and also use Go version 1.18 since this
is the minimum required version.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Without the update build fails on -fno-common toolchains as:
$ nix build --impure --expr 'with import ./. {}; netatalk.override { stdenv = clang13Stdenv; }' -L
...
ld: afpd-volume.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94:
multiple definition of `invalid_dircache_entries'; afpd-afp_dsi.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94: first defined here
ld: afpd-acls.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94:
multiple definition of `invalid_dircache_entries'; afpd-afp_dsi.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94: first defined here
Changes: https://netatalk.sourceforge.io/3.1/ReleaseNotes3.1.13.html
Without the change build fails on toolchains like clang-13 which
switch to -fno-common by default:
$ nix build --impure --expr 'with import ./. {}; ipmitool.override { stdenv = clang13Stdenv; }'
...
ld: ../lib/.libs/libipmitool.a(ipmi_hpmfwupg.o):/build/ipmitool-1.8.18/lib/../include/ipmitool/ipmi_hpmfwupg.h:803:
multiple definition of `gVersionInfo'; ipmitool.o:/build/ipmitool-1.8.18/src/../include/ipmitool/ipmi_hpmfwupg.h:803: first defined here
Pull upstream fix to move definition to .c file.
Sergei Trofimovich