networkmanager-l2tp: 1.2.12 → 1.20.4

- Adds support for GNOME 42.
- Allows using go-l2tp instead of xl2tpd but we do not have the former packaged.
- Removes some old cruft, allowing us to simplify the expression.

https://github.com/nm-l2tp/NetworkManager-l2tp/blob/1.20.4/NEWS

pkgs/tools/networking/networkmanager/l2tp/default.nix

@@ -3,11 +3,9 @@
 , substituteAll
 , fetchFromGitHub
 , autoreconfHook
-, libtool
-, intltool
 , pkg-config
-, file
 , gtk3
+, gtk4
 , networkmanager
 , ppp
 , xl2tpd
@@ -15,19 +13,22 @@
 , libsecret
 , withGnome ? true
 , libnma
+, libnma-gtk4
 , glib
+, openssl
+, nss
 }:
 
 stdenv.mkDerivation rec {
   name = "${pname}${if withGnome then "-gnome" else ""}-${version}";
   pname = "NetworkManager-l2tp";
-  version = "1.2.12";
+  version = "1.20.4";
 
   src = fetchFromGitHub {
     owner = "nm-l2tp";
     repo = "network-manager-l2tp";
     rev = version;
-    sha256 = "0cq07kvlm98s8a7l4a3zmqnif8x3307kv7n645zx3f1r7x72b8m4";
+    sha256 = "VoqPjMQILBYemRE5VD/XwhWi9zL9QxxHZJ2JKtGglFo=";
   };
 
   patches = [
@@ -39,36 +40,32 @@ stdenv.mkDerivation rec {
 
   nativeBuildInputs = [
     autoreconfHook
-    libtool
-    intltool
     pkg-config
-    file
   ];
 
   buildInputs = [
     networkmanager
     ppp
     glib
+    openssl
+    nss
   ] ++ lib.optionals withGnome [
     gtk3
+    gtk4
     libsecret
     libnma
+    libnma-gtk4
   ];
 
   configureFlags = [
-    "--without-libnm-glib"
     "--with-gnome=${if withGnome then "yes" else "no"}"
+    "--with-gtk4=${if withGnome then "yes" else "no"}"
     "--localstatedir=/var"
-    "--sysconfdir=$(out)/etc"
     "--enable-absolute-paths"
   ];
 
   enableParallelBuilding = true;
 
-  preConfigure = ''
-    intltoolize -f
-  '';
-
   passthru = {
     networkManagerPlugin = "VPN/nm-l2tp-service.name";
   };

pkgs/tools/networking/networkmanager/l2tp/fix-paths.patch

@@ -1,22 +1,22 @@
 diff --git a/shared/utils.c b/shared/utils.c
-index c978a1f..d2c36cd 100644
+index 453e277..28716a5 100644
 --- a/shared/utils.c
 +++ b/shared/utils.c
-@@ -52,7 +52,7 @@ nm_find_ipsec (void)
+@@ -39,7 +39,7 @@ check_ipsec_daemon(const char *path)
+ const char *
+ nm_find_ipsec(void)
  {
- 	static const char *ipsec_binary_paths[] =
+-    static const char *ipsec_binary_paths[] = {"/usr/bin/ipsec",
- 		{
++    static const char *ipsec_binary_paths[] = {"@strongswan@/bin/ipsec",
--			"/sbin/ipsec",
+                                                "/sbin/ipsec",
-+			"@strongswan@/bin/ipsec",
+                                                "/usr/sbin/ipsec",
- 			"/usr/sbin/ipsec",
+                                                "/usr/local/sbin/ipsec",
- 			"/usr/local/sbin/ipsec",
+@@ -70,7 +70,7 @@ nm_find_l2tpd(NML2tpL2tpDaemon *l2tp_daemon)
- 			"/sbin/strongswan",
+                                                "/usr/local/sbin/kl2tpd",
-@@ -77,7 +77,7 @@ nm_find_l2tpd (void)
+                                                NULL};
- {
+ 
- 	static const char *l2tp_binary_paths[] =
+-    static const char *xl2tp_binary_paths[] = {"/usr/bin/xl2tpd",
- 		{
++    static const char *xl2tp_binary_paths[] = {"@xl2tpd@/bin/xl2tpd",
--			"/sbin/xl2tpd",
+                                                "/sbin/xl2tpd",
-+			"@xl2tpd@/bin/xl2tpd",
+                                                "/usr/sbin/xl2tpd",
- 			"/usr/sbin/xl2tpd",
+                                                "/usr/local/sbin/xl2tpd",
- 			"/usr/local/sbin/xl2tpd",
- 			NULL